Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HTTPExt package extension #403

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

Drvi
Copy link
Member

@Drvi Drvi commented Nov 13, 2024

So the package is easier to statically precompile on newer Julia versions

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (50ea61f) to head (8d5c9fc).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/FileIO.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   91.53%   87.14%   -4.40%     
==========================================
  Files          10       11       +1     
  Lines         709      708       -1     
==========================================
- Hits          649      617      -32     
- Misses         60       91      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Keno Keno requested a review from SimonDanisch November 18, 2024 17:07
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a regular contributor, so I'll leave it to someone else

@ViralBShah ViralBShah merged commit 8840934 into JuliaIO:master Nov 18, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants